]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
buffer: fix iterator_impl visibility through typedef 10552/head
authorNoah Watkins <noahwatkins@gmail.com>
Wed, 16 Mar 2016 21:12:05 +0000 (14:12 -0700)
committerKefu Chai <kchai@redhat.com>
Tue, 2 Aug 2016 09:01:03 +0000 (17:01 +0800)
commitc6546bb29b25fb96f270257b959426f949eb9418
treee10daeb1e3ce3271d38c9350ca64d32f40565304
parent894a5f8d878d4b267f80b90a4bffce157f2b4ba7
buffer: fix iterator_impl visibility through typedef

The following program doesn't compile because of symbol visibility issues.
While bufferlist::iterator is a class implementation with visibility specified,
it is unclear after google-fu how to do the same through typedef.

int main()
{
 ceph::bufferlist bl;
 ceph::bufferlist::const_iterator it = bl.begin();
 (void)it;
 return 0;
}

[nwatkins@bender ~]$ g++ -Wall -std=c++11 -Iinstall/include -Linstall/lib -o test test.cc -lrados
/tmp/cciR9MUj.o: In function `main':
test.cc:(.text+0x43): undefined reference to `ceph::buffer::list::iterator_impl<true>::iterator_impl(ceph::buffer::list::iterator const&)'
/usr/bin/ld: test: hidden symbol `_ZN4ceph6buffer4list13iterator_implILb1EEC1ERKNS1_8iteratorE' isn't defined
/usr/bin/ld: final link failed: Bad value
collect2: error: ld returned 1 exit status

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
(cherry picked from commit 16bc3e59325d4057d36cd63a57111ab36fbc50fd)
src/include/buffer.h