]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
os/FileStore: reset journal state on umount 1625/head
authorSage Weil <sage@inktank.com>
Tue, 8 Apr 2014 17:52:43 +0000 (10:52 -0700)
committerSage Weil <sage@inktank.com>
Tue, 8 Apr 2014 18:02:40 +0000 (11:02 -0700)
commit4de49e8676748b6ab4716ff24fd0a465548594fc
treefaa15e76a9cc44b4e440b9fcbe8d685e3ee52825
parent1cdb7381c71fcec00a2b5266c6cbce8f0c467b6d
os/FileStore: reset journal state on umount

We observed a sequence like:

 - replay journal
   - sets JournalingObjectStore applied_op_seq
 - umount
 - mount
   - initiate commit with prevous applied_op_seq
 - replay journal
   - commit finishes
   - on replay commit, we fail assert op > committed_seq

Although strictly speaking the assert failure is harmless here, in general
we should not let state leak through from a previous mount into this
mount or else assertions are in general more difficult to reason about.

Fixes: #8019
Signed-off-by: Sage Weil <sage@inktank.com>
src/os/JournalingObjectStore.cc
src/os/JournalingObjectStore.h