]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: make init env methods return an error 20488/head
authorAbhishek Lekshmanan <abhishek@suse.com>
Mon, 12 Feb 2018 17:05:03 +0000 (18:05 +0100)
committerAbhishek Lekshmanan <abhishek@suse.com>
Tue, 20 Feb 2018 15:18:52 +0000 (16:18 +0100)
commit7872a831783e17dcc4d0aa70cffc256afb664f7a
tree94ba305cb6e700854da2622fb90596553cd0a170
parent94922266ce1fc4f4756c2d97ff2c13746d40542f
rgw:  make init env methods return an error

Since web frontends may signal an error when requests are malformed or so, let
us double check this and raise errors early. The current user of this is
civetweb frontend; which can potentially return null from `parse_http_headers`
when a HTTP header without a ":" is supplied at which point headers.value is
null which can lead to undefined behaviour later in RGW.

Fixes: http://tracker.ceph.com/issues/23039
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
12 files changed:
src/rgw/rgw_asio_client.cc
src/rgw/rgw_asio_client.h
src/rgw/rgw_civetweb.cc
src/rgw/rgw_civetweb.h
src/rgw/rgw_client_io.cc
src/rgw/rgw_client_io.h
src/rgw/rgw_fcgi.cc
src/rgw/rgw_fcgi.h
src/rgw/rgw_lib.h
src/rgw/rgw_loadgen.cc
src/rgw/rgw_loadgen.h
src/rgw/rgw_process.cc