]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crush: update choose_args on bucket removal 22120/head
authorSage Weil <sage@redhat.com>
Fri, 18 May 2018 18:11:57 +0000 (13:11 -0500)
committerSage Weil <sage@redhat.com>
Mon, 21 May 2018 13:43:13 +0000 (08:43 -0500)
commit91e1b6fad4c51bf5f8757e8d4b8f3cee5fe959ab
tree4ce0af15c513d31cc4f3c3237341603cae1b310d
parent7e818cd1ad94a5c7c01cb4093ef46d7b73d41a0a
crush: update choose_args on bucket removal

The specific bug I see is that a bucket no longer exists but its
choose_args still does.  However, I'm also taking the opportunity to
verify that the choose_args agrees with the bucket sizes and position
counts everywhere else, too.  Check for

- ids or weight_sets for buckets that don't exist or aren't straw2
- weight_set_positions that don't match the choose_args
  - don't fix this, just warn.  i'm not sure how it would happen.  :/
- weight_set sizes that don't match the bucket size

Fixes: http://tracker.ceph.com/issues/24167
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit a75ffcd17cc171a383315ec9738865de6c455086)
src/crush/CrushWrapper.cc