]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: fc41273) | patch
msg/Accepter: do not unlearn_addr on bind() 2275/head
authorSage Weil <sage@redhat.com>
Mon, 25 Aug 2014 04:18:00 +0000 (21:18 -0700)
committerSage Weil <sage@redhat.com>
Mon, 25 Aug 2014 04:18:00 +0000 (21:18 -0700)
commitf651f93b343f81bd0b4645f5def8ce3f2cf4abed
treeb2991ca9bdc7f10249d62cd9cf36ce15f4b59193tree | snapshot
parentfc41273495bf2c0290d5ec0e9032e3ef39f26e77commit | diff
msg/Accepter: do not unlearn_addr on bind()

It is dangerous to set need_addr = true as it means someone may set the
addr to something else (specifically the port) in a racing thread.

However, it is not necessary: the only reason we added it way back in
5d5045d31a9e10d21b44eb1bd137db9ae53128ff was so that
local_connection->peer_addr would get updated, and bind() now calls that
unconditionally.

Fixes: #9079
Backport: firefly
Signed-off-by: Sage Weil <sage@redhat.com>
src/msg/Accepter.cc diff | blob | history
src/msg/SimpleMessenger.cc diff | blob | history
src/msg/SimpleMessenger.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.