]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
pybind/rados/rados: do not pass prval from stack 23863/head
authorSage Weil <sage@redhat.com>
Mon, 30 Jul 2018 19:18:07 +0000 (14:18 -0500)
committerNathan Cutler <ncutler@suse.com>
Sun, 2 Sep 2018 12:03:46 +0000 (14:03 +0200)
commitbc5e4977f01d2dcde3c0746a4cb25b1b4c7f07f3
treee71f1bb1caa28817221fcc91efe6adcafce4c21d
parent42cfc1b5895a6eee8b7519d555b828ccf60ec2c0
pybind/rados/rados: do not pass prval from stack

The prval is a pointer to an int to write the final completion code of
the rados op.  This can't be on the stack since we immediately leave the
current scope after preparing the op (looong before we do the rados op).

We keep the tuple return value to avoid breaking users of this API
(devicehealth module, gnocchi at a minimum).

Fixes: http://tracker.ceph.com/issues/25175
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 8e36f18cdeaa2088a6ce4aaad61b76283e777270)
src/pybind/rados/rados.pyx