]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
pybind/rados/rados: do not pass prval from stack 23864/head
authorSage Weil <sage@redhat.com>
Mon, 30 Jul 2018 19:18:07 +0000 (14:18 -0500)
committerNathan Cutler <ncutler@suse.com>
Sun, 2 Sep 2018 12:04:26 +0000 (14:04 +0200)
commit0caf2e7bac2290b677dd927ec55a98bfc7a2db42
tree36b6c67b70135538345a2f10bb2e32aeddcd151f
parentae699615bac534ea496ee965ac6192cb7e0e07c0
pybind/rados/rados: do not pass prval from stack

The prval is a pointer to an int to write the final completion code of
the rados op.  This can't be on the stack since we immediately leave the
current scope after preparing the op (looong before we do the rados op).

We keep the tuple return value to avoid breaking users of this API
(devicehealth module, gnocchi at a minimum).

Fixes: http://tracker.ceph.com/issues/25175
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 8e36f18cdeaa2088a6ce4aaad61b76283e777270)
src/pybind/rados/rados.pyx