]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put 24745/head
authorSage Weil <sage@redhat.com>
Mon, 22 Oct 2018 19:38:48 +0000 (14:38 -0500)
committerNathan Cutler <ncutler@suse.com>
Wed, 24 Oct 2018 19:59:25 +0000 (21:59 +0200)
commite76cea690a6f67a09f8b8174d81723b06903657b
treee81be258bc50fec4baa18f6cc480e71a8f18e5e9
parentf51c50eb178c6695a9d88448d467309392a8c764
os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put

A                             B
SharedBlobSet::lookup()
  takes lock
  nref is not 0
                              SharedBlob::put()
                                --nref
returns SharedBlobRef,
  ++nref
                                takes cache lock
                                SharedBlobSet::remove
                                  takes lock
                                  removes
                                deletes SharedBlob

-> A ends up with a ref to deleted SharedBlob

Fix by verifying that nref is still zero in SharedBlobSet::remove(),
while we are holding the SharedBlobSet::lock.  The lock ensures that we
have increased the ref for the lookup before entering remove, so we can
verify that nref is still zero before removing it.  If not, we have
raced, and put() bails out and does nothing.

Fixes: http://tracker.ceph.com/issues/36526
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 020bd7b5f38a82d9eef5e25e6f4a4dd12b066915)

Conflicts:
src/os/bluestore/BlueStore.h
src/os/bluestore/BlueStore.cc
src/os/bluestore/BlueStore.h