]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put 24746/head
authorSage Weil <sage@redhat.com>
Mon, 22 Oct 2018 19:38:48 +0000 (14:38 -0500)
committerNathan Cutler <ncutler@suse.com>
Wed, 24 Oct 2018 20:01:47 +0000 (22:01 +0200)
commit7031addfe6fcd070df8c4c7b175f374bda77a671
tree562c0617a5e73554d279ae5611d67d074a1a1ffc
parent503376f5cf6cc5093870e4ecae4e81ed77524e3d
os/bluestore: fix race between SharedBlobSet::lookup and SharedBlob::put

A                             B
SharedBlobSet::lookup()
  takes lock
  nref is not 0
                              SharedBlob::put()
                                --nref
returns SharedBlobRef,
  ++nref
                                takes cache lock
                                SharedBlobSet::remove
                                  takes lock
                                  removes
                                deletes SharedBlob

-> A ends up with a ref to deleted SharedBlob

Fix by verifying that nref is still zero in SharedBlobSet::remove(),
while we are holding the SharedBlobSet::lock.  The lock ensures that we
have increased the ref for the lookup before entering remove, so we can
verify that nref is still zero before removing it.  If not, we have
raced, and put() bails out and does nothing.

Fixes: http://tracker.ceph.com/issues/36526
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 020bd7b5f38a82d9eef5e25e6f4a4dd12b066915)

Conflicts:
src/os/bluestore/BlueStore.h
src/os/bluestore/BlueStore.cc
src/os/bluestore/BlueStore.h