]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
build/ops: rpm: stop install-deps.sh clobbering spec file Python build setting 25294/head
authorNathan Cutler <ncutler@suse.com>
Tue, 20 Nov 2018 10:43:13 +0000 (11:43 +0100)
committerNathan Cutler <ncutler@suse.com>
Tue, 27 Nov 2018 22:42:31 +0000 (23:42 +0100)
commit8151217cf36c030ac0da315e9079a7d5a53eb572
treeaed7ae40d3ae916e8d13454395e280c08df7ad11
parent40483a61c80db6c021e8fd4cc3b73a98c525d584
build/ops: rpm: stop install-deps.sh clobbering spec file Python build setting

Fedora 29 still ships a Python 2 binary, but some of Ceph's build
dependencies are only available in py3 versions there. In other
words, from F29 on, it is no longer possible to do a py2 Ceph build
on Fedora, even if a python2 binary exists on the system.

If that were not enough, the Python 2 that ships with Fedora 29 is
linked against a non-compatible version of OpenSSL.

Before this commit, install-deps.sh was overriding the spec file's
Python build setting based on the presence or absence of a python2
binary. As the bug cited below indicates, this was not a good idea.

It's better for the spec file to be explicit about which OS versions
are py2 and which are py3, and just stick to that.

Fixes: http://tracker.ceph.com/issues/37301
Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 7d4916618c419e4c85823cf259b96e49d9203035)

Conflicts:
ceph.spec.in
install-deps.sh
- no WITH_SEASTAR in mimic
ceph.spec.in
install-deps.sh