]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Revert "msg/async/Protocol*: send keep alive if existing wins" 26767/head
authorxie xingguo <xie.xingguo@zte.com.cn>
Tue, 5 Mar 2019 11:46:09 +0000 (19:46 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Tue, 5 Mar 2019 12:02:23 +0000 (20:02 +0800)
commitfd520a17db863057f401d206777a95d3458f498e
tree38cee648d3a4cc2b316c2b5a188054841208f508
parente280c1a0df67a2f203f175fef28d40ba3f945af9
Revert "msg/async/Protocol*: send keep alive if existing wins"

This reverts commit 61b9432ef9a3847eceb96f8d5a854567c49bbf61.

If we are in the middle of replacing, we can not queue any further
write events into the old center because we may end up replacing
existing connection's center with a new one, and hence executing
the newly queued write events in the old thread.

See **transfer_existing** for a detailed description.

Also the patch does not make a lot of sense for the original issue
it tried to resolve, because **send_keepalive** is a pure noop if the
underlying connection is not ready, which is obviously true for the
case demonstrated in http://tracker.ceph.com/issues/38493..

Fixes: http://tracker.ceph.com/issues/38569
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/msg/async/ProtocolV1.cc
src/msg/async/ProtocolV2.cc