]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cli: CEPH_ARGS must be before injectargs 2733/head
authorLoic Dachary <loic-201408@dachary.org>
Thu, 16 Oct 2014 15:39:15 +0000 (08:39 -0700)
committerLoic Dachary <loic-201408@dachary.org>
Tue, 21 Oct 2014 06:03:11 +0000 (23:03 -0700)
commit2ec36095693b7ca2dd1f54e70ac563d4f889cb3a
treeef879fbcbfea0f2766efe99abcc6146b6cf37301
parenta566610aaa82d65b48e300559e5435df4a939ca8
cli: CEPH_ARGS must be before injectargs

It is incorrect to append the content of CEPH_ARGS to the argument list
when running injectargs. For instance if

  CEPH_ARGS='--log-file the.log' \
    ./ceph tell osd.0 injectargs --no-osd_debug_op_order

translates into

    ./ceph tell osd.0 injectargs --no-osd_debug_op_order \
                                 --log-file the.log

it ends up changing the log file of osd.0 which is probably unintended.
Instead CEPH_ARGS is inserted before injectargs and it translates into:

    ./ceph tell osd.0 --log-file the.log \
                      injectargs --no-osd_debug_op_order

Signed-off-by: Loic Dachary <loic-201408@dachary.org>
qa/workunits/cephtool/test.sh
src/ceph.in