]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
msg/async: Don't dec(msgr_active_connections) if conn still in accepting_conns. 29836/head
authorJianpeng Ma <jianpeng.ma@intel.com>
Fri, 23 Aug 2019 06:15:43 +0000 (14:15 +0800)
committerJianpeng Ma <jianpeng.ma@intel.com>
Fri, 23 Aug 2019 06:15:43 +0000 (14:15 +0800)
commit5b41e12fdb4452b974e9ec46378a58378e33c3b1
treee106f735fafd68c4b0a736c949a2d353c5574e30
parent1116362118dee7dfd8a970173f60996a0ba6f520
msg/async: Don't dec(msgr_active_connections) if conn still in accepting_conns.

I found this bug during test:
"AsyncMessenger::Worker-0": {
        "msgr_active_connections": 18446744073709313353,
    },

This because before AsyncMessenger::accept_conn, the conn met fault and
stop this conn. In unregister_conn, it will
dec(msgr_active_connections). But the conn it don't inc(msgr_active_connections).
Only erase from accepting_conns, it will inc(msgr_active_connections).

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
src/msg/async/AsyncMessenger.h