]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crush/CrushWrapper: fix create_or_move_item when name exists but item does not 2986/head
authorSage Weil <sage@redhat.com>
Mon, 24 Nov 2014 02:50:51 +0000 (18:50 -0800)
committerSage Weil <sage@redhat.com>
Tue, 9 Dec 2014 00:21:24 +0000 (16:21 -0800)
commit9902383c690dca9ed5ba667800413daa8332157e
tree154d3bb65560abf3f43db5c00667cf7cb5d3d077
parent8c87e9502142d5b4a282b94f929ae776a49be1dc
crush/CrushWrapper: fix create_or_move_item when name exists but item does not

We were using item_exists(), which simply checks if we have a name defined
for the item.  Instead, use _search_item_exists(), which looks for an
instance of the item somewhere in the hierarchy.  This matches what
get_item_weightf() is doing, which ensures we get a non-negative weight
that converts properly to floating point.

Backport: giant, firefly
Fixes: #9998
Reported-by: Pawel Sadowski <ceph@sadziu.pl>
Signed-off-by: Sage Weil <sage@redhat.com>
src/crush/CrushWrapper.cc