]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: Refactor Python unittests 31165/head
authorVolker Theile <vtheile@suse.com>
Wed, 6 Nov 2019 14:02:49 +0000 (15:02 +0100)
committerVolker Theile <vtheile@suse.com>
Tue, 26 Nov 2019 10:54:31 +0000 (11:54 +0100)
commite542255b04457df269587bc5639b14a935a125d3
treeeeac41ea6f88e489e9a26a91e3b60c28ec4f9854
parenta6481f6b6f9a577fc5e881e3b2b451385f06a98d
mgr/dashboard: Refactor Python unittests

* Make use of the KVStoreMockMixin class to get rid off duplicate code.
* Fake the index.html file to be able to run tests/test_home.py locally without building the frontend in production mode.
* Encapsulate helper functions in controllers/home.py, otherwise tests/test_feature_toggles.py need to fake the filesystem because load_controllers() will load the home.py controller and fail due missing files in the filesystem.

Signed-off-by: Volker Theile <vtheile@suse.com>
src/pybind/mgr/dashboard/controllers/__init__.py
src/pybind/mgr/dashboard/controllers/home.py
src/pybind/mgr/dashboard/requirements-lint.txt
src/pybind/mgr/dashboard/requirements-test.txt
src/pybind/mgr/dashboard/tests/__init__.py
src/pybind/mgr/dashboard/tests/test_grafana.py
src/pybind/mgr/dashboard/tests/test_home.py
src/pybind/mgr/dashboard/tests/test_rgw_client.py