]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
osd: dispatch_context and queue split finish on early bail-out 35024/head
authorSage Weil <sage@redhat.com>
Tue, 28 Jan 2020 19:33:49 +0000 (13:33 -0600)
committerNathan Cutler <ncutler@suse.com>
Wed, 13 May 2020 15:33:43 +0000 (17:33 +0200)
commit795262d71aefc26fed5758029cba59ff093b97ab
tree6ffc6276e726ce5f0a7af7eee83cbb2b0754a7cd
parente8f288f17159f5554f1a2fc54d8847695bf97bc8
osd: dispatch_context and queue split finish on early bail-out

If we bail out of advance_pg early because there is an upcoming merge, we
still need to dispatch_context() on rctx before we drop the PG lock.  And
the rctx that we submit needs to include the on_applied finisher comit
to call _finish_splits.

This is noticeable (at least) when there is a split and merge that are
both known.  When we process the split, the new child is added to new_pgs.
When we get to the merge epoch, we stop early and take the bail-out
path.

Fix by adding a dispatch_context call for this path.  And further make sure
that both dispatch_context callers in this function queue up the
new_pgs event.

Fixes: https://tracker.ceph.com/issues/43825
Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 14c4dbb03fe3c7fb4a0a6fa40dcb89e89fb66b3c)

Conflicts:
src/osd/OSD.cc
- where master says "rctx.transaction.register_on_applied", replaced
  with nautilus equivalent: "rctx->transaction->register_on_applied"
- where master says "dispatch_context(rctx, pg, pg->get_osdmap(),
  &handle)", replaced with nautilus equivalent:
  "dispatch_context_transaction(*rctx, pg, &handle)"
src/osd/OSD.cc