]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/devicehealth: fix daemon filtering before scraping device 36741/head
authorYaarit Hatuka <yaarit@redhat.com>
Thu, 20 Aug 2020 18:21:11 +0000 (18:21 +0000)
committerYaarit Hatuka <yaarit@redhat.com>
Thu, 20 Aug 2020 18:47:21 +0000 (18:47 +0000)
commita07af14cff693cfe7d2f2233012ae05ecd7f13de
tree259ebb4fdae90aa5f8ef783906826b8b4e40fe79
parentad9483490311d6d85b67028ef63e8b39fbda58ab
mgr/devicehealth: fix daemon filtering before scraping device

Scraping health metrics of mon devices was introduced in Nautilus, then
disabled (only in Nautilus) since the 'tell' mechanism of mons was not
reliable.
This commit fixes a bug when filtering the daemons on the device to be
scrapped (and allows scraping osd devices solely).

When:
$ ceph device scrape-health-metrics seagate_123
Error EAGAIN: device seagate_123 not claimed by any active OSD daemons

But:
$ ceph device ls
DEVICE         HOST:DEV      DAEMONS   LIFE EXPECTANCY
seagate_123 hostname:sdc osd.1

See:
Introducing the feature in Nautilus:
PR: https://github.com/ceph/ceph/pull/24151
commit: 8d786003a44313c85c038cbdc9bd9875da197ab1

Disabling the feature in Nautilus:
PR: https://github.com/ceph/ceph/pull/31446
commit: d592e56e74d94c6a05b9240fcb0031868acefbab

This issue exists only in Nautilus and does not require fixes in any other branch.

Fixes: https://tracker.ceph.com/issues/46871
Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
src/pybind/mgr/devicehealth/module.py