]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rbd: make common options override krbd-specific options 37385/head
authorIlya Dryomov <idryomov@gmail.com>
Thu, 24 Sep 2020 08:50:24 +0000 (10:50 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 24 Sep 2020 08:50:24 +0000 (10:50 +0200)
commita107c47360ecdb8c09768ca9eab2341100245711
tree4ea482b1af4dae081fe29680c2bb0a3d5be1fd7d
parent6827bbbcfbd1a36525f90ced26cf74d0b1f9eabc
rbd: make common options override krbd-specific options

ceph-csi has added support for passing custom map and unmap options via
mapOptions and unmapOptions storage class parameters.  However, it also
uses --read-only for implementing ROX (ReadOnlyMany) PVs.  If the user
supplies "mapOptions: rw", they will get around the intended read-only
restriction (at least on the block device).

ceph-csi could be patched to use "-o ro", but it actually makes sense
for common options to win over device type-specific equivalents.

Fixes: https://tracker.ceph.com/issues/47625
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
doc/man/8/rbd.rst
qa/rbd/krbd_blkroset.t
src/tools/rbd/action/Kernel.cc