]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: Drop invalid RGW client instances, improve logging 38584/head
authorVolker Theile <vtheile@suse.com>
Tue, 15 Dec 2020 09:40:48 +0000 (10:40 +0100)
committerVolker Theile <vtheile@suse.com>
Mon, 4 Jan 2021 10:21:36 +0000 (11:21 +0100)
commitec0444d6a139b72c3960cf12724a1d483be23857
tree6e67927d72199817c1848738e8f8c5e5aadb9325
parent74f48adff35db6f86e9231614da019ef946277a3
mgr/dashboard: Drop invalid RGW client instances, improve logging

* Log RGW settings for easier problem tracking.
* Drop RGW client instances that do not exist anymore. This happens when a RGW service is removed via the orchestrator. The Dashboard tries to access the RGW client using the previous settings which leads to an error which might be confusing. Without dropping the error message 'RGW REST API failed request ...' is displayed instead of the correct one 'No RGW found'. Dropping the RGW client instance will produce correct error messages the next time the backend tries to establish a new connection.

Fixes: https://tracker.ceph.com/issues/48586
Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit 495ff0a2cf1713312deba3b61da6d213019fc920)

Conflicts:
  Need to remove type hints.
  src/pybind/mgr/dashboard/services/rgw_client.py
src/pybind/mgr/dashboard/controllers/rgw.py
src/pybind/mgr/dashboard/services/rgw_client.py