]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/PyModule: correctly remove config options 38803/head
authorTim Serong <tserong@suse.com>
Fri, 22 Nov 2019 09:25:19 +0000 (20:25 +1100)
committerNathan Cutler <ncutler@suse.com>
Thu, 7 Jan 2021 12:44:42 +0000 (13:44 +0100)
commitebefb2081d79812811a39a949e55b1264b3f3c3f
treedaab2752b8767c6580d1f1b6f5819163ab8336b9
parent0aed223b682263a84591b7d535ae7966a0f9fa99
mgr/PyModule: correctly remove config options

Previously, incorrect parameters were being passed to "config rm",
causing it to do nothing.  This commit also ensures the correct
error message is shown for both the set and remove failure cases.
I've also moved the update of the in-memory config map to *after*
the value is persisted, to ensure the config map actually reflects
what's stored.

Fixes: https://tracker.ceph.com/issues/42958
Signed-off-by: Tim Serong <tserong@suse.com>
(cherry picked from commit 0520ff571cfb480872c8bd429c94bd4ce15eeb40)
src/mgr/PyModule.cc