]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw_file: return common_prefixes in lexical order 38829/head
authorMatt Benjamin <mbenjamin@redhat.com>
Fri, 8 Jan 2021 18:23:56 +0000 (13:23 -0500)
committerNathan Cutler <ncutler@suse.com>
Fri, 8 Jan 2021 18:31:28 +0000 (19:31 +0100)
commit1c0a4a78a5360709650ff4f5984dab8ee24ca9d3
tree0f4dad9474057f3c0dd8596bfb90c5dca1ce4490
parent79adcfe1c91d71a042ed33a77a29dea96f116e6e
rgw_file: return common_prefixes in lexical order

Since inception RGWReaddirRequest has sent all leaf objects first
(in lexical order), then common_prefixes (in lexical order). In
hindsight, an overall listing could trivially be returned out of
lexical order, which can cause continued listing of large, mixed
directories to fail.

RCA by Dan Gryniewicz.

Fixes: https://tracker.ceph.com/issues/48410
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit e561e98e5cca2678854e01c990f95e474022b7ed)

Conflicts:
        src/rgw/rgw_file.h
src/rgw/rgw_file.h