]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
osd: Remove override for osd_async_recovery_min_cost for mclock profiles 38941/head
authorSridhar Seshasayee <sseshasa@redhat.com>
Mon, 18 Jan 2021 08:34:46 +0000 (14:04 +0530)
committerSridhar Seshasayee <sseshasa@redhat.com>
Mon, 18 Jan 2021 13:37:11 +0000 (19:07 +0530)
commit922d93f4491207411b4ee9427e49ccf08b0ef648
tree01cf859b0282f2039ac3c30980b2664938bf922b
parent0e7a7be5c065bd7f792b378a59c14b503370e394
osd: Remove override for osd_async_recovery_min_cost for mclock profiles

Overriding osd_async_recovery_min_cost as part of enabling a built-in
mclock profile has the undesirable side effect of peers not choosing
the correct async recovery targets if osds are using mixed schedulers
(this could happen during upgrades or if "debug_random" is set for
osd_op_queue config option). Due to the above, osds get into a
"choose_acting" loop during peering.

The solution is to remove the override of osd_async_recovery_min_cost.

Fixes: https://tracker.ceph.com/issues/48906
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
src/osd/OSD.cc
src/osd/scheduler/mClockScheduler.cc