]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common/options: turn off bluestore_fsck_quick_fix_on_mount by default 40309/head
authorJosh Durgin <jdurgin@redhat.com>
Wed, 17 Mar 2021 18:51:27 +0000 (14:51 -0400)
committerNeha Ojha <nojha@redhat.com>
Mon, 22 Mar 2021 14:31:56 +0000 (14:31 +0000)
commit65b0a459d553dc7f22a09e465ce84f1bdb2b2521
treebc682095757871ff54245d36e9740e4b2eaf03a2
parenta7f61d8f56bc32989402b53c43b5bde9dd564a95
common/options: turn off bluestore_fsck_quick_fix_on_mount by default

This option enables 3 conversions:

1) pool stats, added in nautilus
2) per-pool omap, added in octopus
3) per-pg omap (replacing (2)) in pacific

Upgrading the long running cluster in sepia from octopus to pacific
resulted in conversion (3). This conversion isn't particularly useful
yet since the follow-on optimization of pg removal aren't in pacific
yet.

This took 25 minutes for the SSD-based osds with <10GB of omap. That's
a lot of disruption, and some clusters have 10x that much omap data.

Upgrades going from nautilus to pacific will miss the finer-grained
stats granularity, but isn't such an important feature it's worth
causing potential availability problems.

In the future we can orchestrate these format changes via cephadm/rook
to minimize the impact on the whole cluster, e.g. going an osd at a
time or doing it during an off-peak period, and not necessarily at the
same time as an upgrade.

Fixes: https://tracker.ceph.com/issues/45265
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
(cherry picked from commit c3e7acb3acd4b099c12062aadf7d413d80ab0cab)
src/common/options.cc