]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mon/ConfigMonitor: do not indent 'config dump' output 40556/head
authorSage Weil <sage@newdream.net>
Thu, 1 Apr 2021 19:22:07 +0000 (14:22 -0500)
committerSage Weil <sage@newdream.net>
Thu, 1 Apr 2021 19:22:07 +0000 (14:22 -0500)
commite0ff3bf8894e7dc81bca5308ab511009915ad4ce
tree722fee14d1b77c48462b713526f12fe293f83a20
parent777304220adc6c8e8c0531ddda37d0d0dced79de
mon/ConfigMonitor: do not indent 'config dump' output

The indentation is misleading.  For example,

  mgr                                  advanced  mgr/telemetry/last_opt_revision       3                                                                                  *
  osd                                  advanced  osd_max_backfills                     10
  osd                                  basic     osd_memory_target                     6442450944
  osd                                  advanced  osd_scrub_auto_repair                 true
    mds.ar                             basic     mds_join_fs                           ar
    client.rgw.foo                     basic     rgw_frontends                         beast port=8080                                                                    *

The indentation kind of implies that mds.ar (or client.whatever) is
beneath 'osd', which it is not, and there rarely a 'client' scoped
option to make it look right.  Same problem for osd.foo etc.

Also, it is IMO easier to see the nesting structure when things align
naturally. e.g.

global
osd
osd.1
osd.2
mds
mds.foo
mds.foo.bar
client.foo.bar
...

Signed-off-by: Sage Weil <sage@newdream.net>
src/mon/ConfigMonitor.cc