]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rbd-mirror: fix segfault in snapshot replayer shutdown 41480/head
authorArthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Fri, 21 May 2021 15:05:24 +0000 (17:05 +0200)
committerArthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Fri, 21 May 2021 16:44:37 +0000 (18:44 +0200)
commit3bc07f6ce06151d96949becb2be423cfabf01429
tree8ad4da76f11bcfd42350b72adf3c7b271b02e78a
parentbc5e67e1c9aeaed8342db7f7fbcfcf3a17206094
rbd-mirror: fix segfault in snapshot replayer shutdown

If an error arises in the init flow of the snapshot replayer and the
function returns before the call on `register_local_update_watcher`
the value of `m_update_watch_ctx` will not be initialized. Therefore,
on the shutdown phase, the replayer will try to free this pointer
and segfault.

This commit fixes this issue by setting `m_update_watch_ctx` to
`nullptr`.

Fixes: https://tracker.ceph.com/issues/50931
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
src/tools/rbd_mirror/image_replayer/snapshot/Replayer.h