]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
osd/PeeringState: fix acting_set_writeable min_size check 41609/head
authorSamuel Just <sjust@redhat.com>
Fri, 2 Apr 2021 22:30:54 +0000 (22:30 +0000)
committerDan van der Ster <daniel.vanderster@cern.ch>
Tue, 1 Jun 2021 08:44:36 +0000 (10:44 +0200)
commit158916bd6a034f9fb43d125f0b62b008ed1b0794
treef3895f81df904825ecdc76d3d63948b387633a41
parent947cb10afb63d33a5c1ab91c139324a4601e4fbb
osd/PeeringState: fix acting_set_writeable min_size check

acting.size() >= pool.info.min_size is meant to check min_size against
acting set participants, but acting is a vector with placeholders.
actingset is the representation with placeholders removed.

The upshot of this bug is that the activation process will basically
ignore min_size for an ec pool allowing writes in cases where it
shouldn't.  PastIntervals::check_new_interval, however, performs
the check correctly, and will therefore discount intervals in which
we really did serve writes as not writeable.  This can trigger many
different problem conditions including but not limited to:
  - Unfound objects due to accepting a last_update with insufficient
    osds
  - Lost writes
  - Crashes due to peering rules being violated

This bug was originally introduced with recovery below min_size in
e5a96fd, and then preserved through refactors in 749a13d and 95bec9.

7cb818a exposed it with with expansion of recovery below min_size
to include ec pools (acting.size() is sufficient for replicated
pools).

Fixes: https://tracker.ceph.com/issues/48613
Fixes: https://tracker.ceph.com/issues/48417
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 642a1c165499bcbd4cfdf907af313ac7ffe44ff4)

Conflicts:
src/osd/PeeringState.h

Fixes the callers rather than also backporting 95bec9873.
src/osd/PeeringState.cc