]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: cleanup virtual dtor decls and defns 42249/head
authorKaleb S. KEITHLEY <kkeithle@redhat.com>
Thu, 8 Jul 2021 17:15:08 +0000 (13:15 -0400)
committerKaleb S. KEITHLEY <kkeithle@redhat.com>
Fri, 9 Jul 2021 12:45:15 +0000 (08:45 -0400)
commit65d9389a19847df3c0b0e6044601f1ffd6cd5311
tree24458f360726769b5fdebe325eac60bb53f0adc2
parent7a31ae31584fdb967c470974034070ce9e687ac7
rgw: cleanup virtual dtor decls and defns

working on zipper loadable modules reveals issues with dtors in several classes.

These manifest as undefined references to vtable and typeinfo when linking librgw.so.

(Note: you won't see these until more zipper work is merged.)
This is due to:

    some classes don't declare a dtor at all
    some classes don't declare the dtor as virtual
    some classes define the dtor inline in the decl in the .h
    some classes don't have a defn at all
    etc.

https://tracker.ceph.com/issues/51599
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
21 files changed:
src/rgw/rgw_coroutine.cc
src/rgw/rgw_coroutine.h
src/rgw/rgw_cr_rados.h
src/rgw/rgw_multi.cc
src/rgw/rgw_multi.h
src/rgw/rgw_op.cc
src/rgw/rgw_op.h
src/rgw/rgw_sal_rados.cc
src/rgw/rgw_sal_rados.h
src/rgw/rgw_service.cc
src/rgw/rgw_service.h
src/rgw/rgw_sync.cc
src/rgw/rgw_sync.h
src/rgw/rgw_zone.cc
src/rgw/rgw_zone.h
src/rgw/services/svc_config_key_rados.cc
src/rgw/services/svc_config_key_rados.h
src/rgw/services/svc_notify.cc
src/rgw/services/svc_notify.h
src/rgw/services/svc_tier_rados.cc
src/rgw/services/svc_tier_rados.h