]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mds: ignore unknown client op when tracking op latency 44291/head
authorVenky Shankar <vshankar@redhat.com>
Mon, 13 Dec 2021 06:15:19 +0000 (01:15 -0500)
committerVenky Shankar <vshankar@redhat.com>
Mon, 3 Jan 2022 08:52:05 +0000 (14:22 +0530)
commit2f4060b8c41004d10d9a64676ccd847f6e1304dd
tree9afe888c6aa3ecc0b1918b56ed7b30e268f99a0e
parenta2f5a3c1dbfa4dce41e25da4f029a8fdb8c8d864
mds: ignore unknown client op when tracking op latency

Server::handle_client_request() ignores unknown client operation
by returning -ENOTSUPP, however, Server::perf_gather_op_latency()
aborts on unknown client op, thereby causing -ENOTSUPP to never
reach the client. ceph_abort() seems unnecessary here.

Note, we could have invoked Server::perf_gather_op_latency()
when the return value to client is not -ENOTSUPP, however,
a valid client operation *might* just return -ENOTSUPP in
some cases.

@mchangir ran into this with his getvxattr op changes (PR #42001).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
src/mds/Server.cc