]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/devicehealth: fix missing timezone from time delta calculation 44325/head
authorYaarit Hatuka <yaarit@redhat.com>
Mon, 4 Oct 2021 18:50:01 +0000 (18:50 +0000)
committerKonstantin Shalygin <k0ste@k0ste.ru>
Wed, 15 Dec 2021 18:37:22 +0000 (01:37 +0700)
commit076cabf7c51e7157e299fdc3122273e1965f0fdb
treee828e7dde2e076a7726e5028653bd8aaa9d29ac6
parentd36071b4931fb9d6810eb6147b3b7069549387b1
mgr/devicehealth: fix missing timezone from time delta calculation

An error occurs when subtracting a datetime object that is offset-naive
(i.e. unaware of timezone) from a datetime object which is offset-aware.

datetime.utcnow() is missing timezone info, e.g.:
'2021-09-22 13:18:45.021712',
while life_expectancy_max is in the format of:
'2021-09-28 00:00:00.000000+00:00',
hence we need to add timezone info to the former when calculating
their time delta.

Please note that we calculate time delta using `datetime.utcnow()` in
`serve()` in this module, but there we refer to the delta in seconds,
which works fine.

Fixes: https://tracker.ceph.com/issues/52327
Signed-off-by: Yaarit Hatuka <yaarit@redhat.com>
(cherry picked from commit 05902d943bba4a64abbd943270b56cbdd1650e62)
src/pybind/mgr/devicehealth/module.py