]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 481093b) | patch
cls/rbd: GroupSnapshotNamespace comparator violates ordering rules 45021/head
authorIlya Dryomov <idryomov@gmail.com>
Mon, 14 Feb 2022 12:04:00 +0000 (13:04 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 14 Feb 2022 12:31:54 +0000 (13:31 +0100)
commit830e72ab9d66c8f5703ea27da5249b02dd16ccd0
tree8b84f7cc089652385490f539430f3d8b3761e02dtree | snapshot
parent481093b7f6d23f6121fefc59b2ddc68b5fd2d953commit | diff
cls/rbd: GroupSnapshotNamespace comparator violates ordering rules

For

  GroupSnapshotNamespace a(1, "group-1", "snap-2");
  GroupSnapshotNamespace b(1, "group-2", "snap-1");

both a < b and b < a evaluate to true.  This violates STL strict weak
ordering requirements which is a problem because GroupSnapshotNamespace
is used as a key in std::map (ictx->snap_ids at least), etc.

Fixes: https://tracker.ceph.com/issues/49792
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/cls/rbd/cls_rbd_types.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.