]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rbd-mirror: make mirror properly detect pool replayer needs restart 45086/head
authorMykola Golub <mgolub@suse.com>
Fri, 18 Feb 2022 10:42:23 +0000 (10:42 +0000)
committerMykola Golub <mgolub@suse.com>
Fri, 18 Feb 2022 18:33:20 +0000 (18:33 +0000)
commitad4a2990b87834fe4ae8c9111547d071aa6e75e5
treece6bbc8c9774c136439d054aed70488c7a698036
parentcee3cae9b2d1ea14db0ffaf3984486d278ff8871
rbd-mirror: make mirror properly detect pool replayer needs restart

When a PoolReplayer detects remote pool metadata change it
sets "stopping" flag expecting the Mirror will restart it.

Although setting "stopping" flag makes the PoolReplayer::run
thread to terminate, the thread's is_started function will still
return true until join is called (and reset the thread id).

This made impossible for the Mirror to detect (by calling
PoolReplayer::is_running) that the PoolReplayer needed restart.

Fixes: https://tracker.ceph.com/issues/54258
Signed-off-by: Mykola Golub <mgolub@suse.com>
src/tools/rbd_mirror/PoolReplayer.cc