]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: in bucket reshard list, clarify new num shards is tentative 45509/head
authorJ. Eric Ivancich <ivancich@redhat.com>
Wed, 22 Dec 2021 19:45:59 +0000 (14:45 -0500)
committerCory Snyder <csnyder@iland.com>
Thu, 17 Mar 2022 14:35:04 +0000 (10:35 -0400)
commitf3f8d70561c4458929a91d1af5d08ca65b7dc45c
tree36404c01e2eded81c98911f1871b498c7214f034
parent179a7bca8a84771b0dde09e26f7a2146a985df90
rgw: in bucket reshard list, clarify new num shards is tentative

With dynamic bucket index resharding, when the average number of
objects per shard exceeds the configured value, that bucket is
scheduled for reshard. That bucket may receive more new objects before
the resharding takes place. As a result, the existing code
re-calculates the number of new shards just prior to resharding,
rather than waste a resharding opportunity with too low a value.

The same holds true for a user-scheduled resharding.

A user reported confusion that the number reported in `radosgw-admin
reshard list` wasn't the number that the reshard operation ultimately
used. This commit makes it clear that the new number of shards is
"tentative". And test_rgw_reshard.py is updated to reflect this
altered output.

Additionally this commit adds some modernization and efficiency to the
"reshard list" subcommand.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit aa0071ce8b8594b92c0bed2be7a9bf35bfff8cac)

Conflicts:
src/rgw/rgw_admin.cc

Cherry-pick notes:
- Confict caused by reshard.list not having dout prefix provider arg in Pacific
qa/workunits/rgw/test_rgw_reshard.py
src/cls/rgw/cls_rgw_types.cc
src/rgw/rgw_admin.cc