]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
client: stop retrying the request when exceeding 256 times 45728/head
authorXiubo Li <xiubli@redhat.com>
Thu, 31 Mar 2022 07:16:49 +0000 (15:16 +0800)
committerXiubo Li <xiubli@redhat.com>
Mon, 23 May 2022 06:05:25 +0000 (14:05 +0800)
commit8a50329d56c22aeb67793f75db1fba204239b670
tree643feb1d7821da075a4bad87504d628b33b8dde8
parent48e9ada562833d5033031fad43c73a3e9b6e4761
client: stop retrying the request when exceeding 256 times

The type of 'retry_attempt' in 'MetaRequest' is 'int', while in
'ceph_mds_request_head' the type of 'num_retry' is '__u8'. So in
case the request retries exceeding 256 times, the MDS will receive
a incorrect retry seq.

In this case it's ususally a bug in MDS and continue retrying the
request makes no sense. For now let's limit it to 256. In future
this could be fixed in ceph code, so avoid using the hardcode here.

Fixes: https://tracker.ceph.com/issues/55144
Signed-off-by: Xiubo Li <xiubli@redhat.com>
src/client/Client.cc