]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mds: Don't blocklist clients in any replay state 46833/head
authorKotresh HR <khiremat@redhat.com>
Fri, 24 Jun 2022 07:17:57 +0000 (12:47 +0530)
committerKotresh HR <khiremat@redhat.com>
Fri, 24 Jun 2022 10:08:12 +0000 (15:38 +0530)
commit733fb72acfeb79adbb26166ca13b1e5927cd6547
tree0bdb36be97406cc1322a42e8d7f91ab3e733d5de
parent2f71185ad6b2ca79b4f8f981c68873e1a057f9cf
mds: Don't blocklist clients in any replay state

The mds in 'standby-replay' state should not blocklist clients.
Attempting to do so would hit an assert while journaling.

Before the commit 79f7576 the 'Server:apply_blocklist' used to
fetch the blocklist addresses from 'Objecter::consume_blocklist_events'
which returns blocklist addresses only if 'blocklist_events_enabled'
are enabled. This is not enabled for mds in 'standby-replay' state.
Hence this issue wasn't seen.

After the commit 79f7576 the 'Server::apply_blocklist' fetches the
blocklist addresses from the osdmap. This would return the blocklist
addresses irrespective of the mds state. The mds in 'replay' state
doesn't blocklist the clients but if the mds is in 'standby-replay'
state, it tries to journal the blocklist and asserts. This patch
fixes the same by not allowing the blocklist if the mds is in any
replay state.

Introduced-by: 79f7576401cc9d857f84396314d7476336c0e271
Fixes: https://tracker.ceph.com/issues/56012
Signed-off-by: Kotresh HR <khiremat@redhat.com>
src/mds/MDSRank.cc