]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
crimson/osd: fix ignoring --no-mon-config 46965/head
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Tue, 5 Jul 2022 12:20:23 +0000 (12:20 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Tue, 5 Jul 2022 12:46:16 +0000 (12:46 +0000)
commit38cb07c756efbdeab6eb7e66507ac6eebd64715f
tree4a850a20f93e3170ccf38ce4df2210810034d09a
parent1b2f250ed95de88b124361aea17b20c62bec7f58
crimson/osd: fix ignoring --no-mon-config

Before we were treating the `--no-mon-config` as one of the
`seastar_n_early_args`. However, this was wrong as it truly
belongs to `config_proxy_args` as:

```cpp
int md_config_t::parse_argv(ConfigValues& values,
                            const ConfigTracker& tracker,
                            std::vector<const char*>& args, int level)
{
    // ...
    else if (ceph_argparse_flag(args, i, "--no-mon-config", (char*)NULL)) {
      values.no_mon_config = true;
    }
    // ...
}
```

The net result of this ignoring `--no-mon-config` which was
the reason behind many dead jobs at Sepia.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/crimson/osd/main.cc