]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Removed unnecessary inclusion of iostream 4707/head
authorMichal Jarzabek <stiopa@gmail.com>
Mon, 11 May 2015 16:46:12 +0000 (17:46 +0100)
committerMichal Jarzabek <stiopa@gmail.com>
Tue, 9 Jun 2015 06:26:56 +0000 (07:26 +0100)
commit83f819877fd421eb5e346f749dcc648c42da84c3
tree66a946ba30daf6b3a016d933638114c874398395
parent142a6ce7119ac20bc55b2765ab90b3e1ba34a73f
Removed unnecessary inclusion of iostream

In several files the iostream wasn't being used, so it got removed.
In other files the iostream inclusion was replaced by including iosfwd
(for forward declarations), which is much smaller header than iostream,
  so in theory should reduce compilation time.
To make this work some of the functions must have been moved from .h to .cc file.
3 functions also needed to have inline removed - this shouldn't affect
performance in any way: two of them are
probably too long to have been inlined anyway and the third one is for
error reporting, so probably won't be called too often.

test/Makefile-client.am: added linker libs

This was required to avoid linker error when linking
src/test/cls_rbd/test_cls_rbd.cc file. Makefile was specyfing
libcommon.a as a part of a linker command even though this wasn't
required and wasn't being linked against. When inline functions from
buffer.h were moved to buffer.cc(and inline was removed) the
libcommon.a library became necessary. This wouldn't link without also
including additional libraries(CRYPTO_LIBS and EXTRA_LIBS)

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
29 files changed:
src/common/ConfUtils.cc
src/common/Formatter.h
src/common/buffer.cc
src/common/ceph_context.h
src/common/ceph_json.h
src/crush/CrushWrapper.h
src/erasure-code/ErasureCode.cc
src/erasure-code/ErasureCodeInterface.h
src/global/global_context.h
src/include/Context.h
src/include/buffer.h
src/include/filepath.h
src/include/object.h
src/include/rangeset.h
src/librbd/WatchNotifyTypes.h
src/mds/CDir.h
src/mds/CInode.h
src/msg/xio/XioPool.h
src/rgw/rgw_acl.h
src/rgw/rgw_acl_s3.cc
src/rgw/rgw_acl_s3.h
src/rgw/rgw_acl_swift.h
src/rgw/rgw_cors.h
src/rgw/rgw_cors_s3.h
src/rgw/rgw_cors_swift.h
src/rgw/rgw_xml.h
src/test/Makefile-client.am
src/test/librados/test.cc
src/test/osd/Object.cc