]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
qa: fix _run_mount_cmd() and _get_mount_cmd() args in vstart_runner 48473/head
authordparmar18 <dparmar@redhat.com>
Thu, 13 Oct 2022 10:52:06 +0000 (16:22 +0530)
committerdparmar18 <dparmar@redhat.com>
Tue, 29 Nov 2022 11:12:22 +0000 (16:42 +0530)
commitd96a7347d848ac00f418d9f79b197146313ad75c
treef3b7d1b6347119f87bab2bf66a1880a822f59f61
parent5570c8c8cd5246edcd281a268322f2277ac35fab
qa: fix _run_mount_cmd() and _get_mount_cmd() args in vstart_runner

commit https://github.com/ceph/ceph/commit/483b16062dc6c7a7c9b0110c17dc802227d560e9
brought in a new arg 'mntargs' and this resulted in errors like:

2022-10-13 01:57:37,519.519 INFO:__main__:ERROR: test_client_metrics_and_metadata (tasks.cephfs.test_mds_metrics.TestMDSMetrics)
2022-10-13 01:57:37,519.519 INFO:__main__:----------------------------------------------------------------------
2022-10-13 01:57:37,519.519 INFO:__main__:Traceback (most recent call last):
2022-10-13 01:57:37,519.519 INFO:__main__:  File "/home/dparmar/cephbuild_run_but_no_edits/ceph/qa/tasks/cephfs/test_mds_metrics.py", line 21, in setUp
2022-10-13 01:57:37,519.519 INFO:__main__:    super(TestMDSMetrics, self).setUp()
2022-10-13 01:57:37,519.519 INFO:__main__:  File "/home/dparmar/cephbuild_run_but_no_edits/ceph/qa/tasks/cephfs/cephfs_test_case.py", line 180, in setUp
2022-10-13 01:57:37,519.519 INFO:__main__:    self.mounts[i].mount_wait()
2022-10-13 01:57:37,519.519 INFO:__main__:  File "/home/dparmar/cephbuild_run_but_no_edits/ceph/qa/tasks/cephfs/mount.py", line 505, in mount_wait
2022-10-13 01:57:37,519.519 INFO:__main__:    self.mount(**kwargs)
2022-10-13 01:57:37,519.519 INFO:__main__:  File "/home/dparmar/cephbuild_run_but_no_edits/ceph/qa/tasks/cephfs/fuse_mount.py", line 52, in mount
2022-10-13 01:57:37,519.519 INFO:__main__:    return self._mount(mntopts, mntargs, check_status)
2022-10-13 01:57:37,519.519 INFO:__main__:  File "/home/dparmar/cephbuild_run_but_no_edits/ceph/qa/tasks/cephfs/fuse_mount.py", line 68, in _mount
2022-10-13 01:57:37,519.519 INFO:__main__:    retval = self._run_mount_cmd(mntopts, mntargs, check_status)
2022-10-13 01:57:37,519.519 INFO:__main__:TypeError: LocalFuseMount._run_mount_cmd() takes 3 positional arguments but 4 were given

This new arg needs to be added in vstart_runner to prevent this.

Introduced-By: https://github.com/ceph/ceph/commit/483b16062dc6c7a7c9b0110c17dc802227d560e9
Fixes: https://tracker.ceph.com/issues/58088
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
qa/tasks/vstart_runner.py