]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: iscsi username and password defaults to admin 49309/head
authorNizamudeen A <nia@redhat.com>
Thu, 29 Sep 2022 19:59:39 +0000 (01:29 +0530)
committerAdam King <adking@redhat.com>
Wed, 7 Dec 2022 17:09:32 +0000 (12:09 -0500)
commitd454b607c6de0c8784a046368d6ed41d86e1cca6
tree8a1ebbbcf7a4ba841db2ebf816936f1a6d798d3e
parent2a41a65abd7d41a3988c0cf8254ee27e42d346f3
mgr/cephadm: iscsi username and password defaults to admin

A while ago, the iscsi username and password were defaulted to admin the
config_dashboard part. But it was not saved to the
`iscsi-gateway.cfg.j2` which results in a misconfiguration.

For eg, if you deploy an iscsi service with service_spec which doesn't
have the api_user and api_password field it results the dashboard to
show the gateways as always down because dashboard was unable to make
request to the iscsi server and every api calls result in a `[dashboard
ERROR rest_client] iscsi REST API failed GET req status: 401`.

Fixes: https://tracker.ceph.com/issues/57730
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit bf87bc797ff0b47a60f7169698bb8ed2a5080c14)
src/pybind/mgr/dashboard/services/tcmu_service.py
src/python-common/ceph/deployment/service_spec.py
src/python-common/ceph/tests/test_service_spec.py