]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mon/MDSMonitor: batch last_metadata update with pending 52230/head
authorPatrick Donnelly <pdonnell@redhat.com>
Tue, 4 Apr 2023 18:03:49 +0000 (14:03 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Wed, 28 Jun 2023 15:29:32 +0000 (11:29 -0400)
commit3e411a2067e433dd4dbc7e4da8a8d2529ee58ff8
tree0c68e9f782858804b95f5be65e95a0c71ba31c67
parentcd4fb827e9def22b0c1de8ef6c244c16cf05b9a2
mon/MDSMonitor: batch last_metadata update with pending

I believe the problem here is that the last_metadata change is lost in a
ECANCELED/EAGAIN transaction but the pending map change goes through in
the next one. I've been unable to find an exact way to reproduce this.
The problem seems to occur when upgrades are performed which would
indicate shuffling in the monitors where quorum would be lost repeatedly.

This seems to be the most likely explanation so let's go ahead and make
this change even without the reproducer. In any case, it has the added
benefit of batching the pending map update (to up:standby) with the
last_metadata update.

Fixes: https://tracker.ceph.com/issues/24403
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 6f69fe9739a23974a46a4e13e4c29b431d95acc4)
src/mon/MDSMonitor.cc