]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr: register OSDs in ms_handle_accept 52292/head
authorPatrick Donnelly <pdonnell@redhat.com>
Mon, 3 Jul 2023 00:48:44 +0000 (20:48 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Mon, 10 Jul 2023 21:12:11 +0000 (17:12 -0400)
commit69980823e62f67d502c4045e15c41c5c44cd5127
treeb7846674853bf49b449324553706493fcfc9a8e1
parent3e2075103a0ab6b7ced5800db1d44d13b1c8b7e6
mgr: register OSDs in ms_handle_accept

It's a no-no to acquire locks in these "fast" messenger methods. This
can lead to messenger slow downs in the best case as it's blocking reads
on the wire. In the worse case, the messenger may deadlock with other
threads, preventing any further message reads off the wire.

It's not obvious this method is "fast" so I've added a comment regarding
this.

Fixes: https://tracker.ceph.com/issues/61874
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
src/mgr/DaemonServer.cc
src/mgr/DaemonServer.h