]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr: register OSDs in ms_handle_accept 53189/head
authorPatrick Donnelly <pdonnell@redhat.com>
Mon, 3 Jul 2023 00:48:44 +0000 (20:48 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Mon, 28 Aug 2023 13:50:19 +0000 (09:50 -0400)
commit355131defb8245ee360502ee08ff5b52479fc95c
treedefe509e611fd4c3119a63a6378962d28389f62c
parent10dbcf74e7e67514005a079972ef0cd7560130cd
mgr: register OSDs in ms_handle_accept

It's a no-no to acquire locks in these "fast" messenger methods. This
can lead to messenger slow downs in the best case as it's blocking reads
on the wire. In the worse case, the messenger may deadlock with other
threads, preventing any further message reads off the wire.

It's not obvious this method is "fast" so I've added a comment regarding
this.

Fixes: https://tracker.ceph.com/issues/61874
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 69980823e62f67d502c4045e15c41c5c44cd5127)
src/mgr/DaemonServer.cc
src/mgr/DaemonServer.h