]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: fix http error checks in keystone/barbican/vault clients 53764/head
authorCasey Bodley <cbodley@redhat.com>
Thu, 5 Oct 2023 15:59:52 +0000 (11:59 -0400)
committerCasey Bodley <cbodley@redhat.com>
Wed, 11 Oct 2023 21:48:38 +0000 (17:48 -0400)
commit373dbd4da2482d12685a53a2986b1f27dc8beaff
treed1a995300cc155127920c6108a4f4eb2d148da01
parent026112f07651f3c639df7ea24379843333fa3a48
rgw: fix http error checks in keystone/barbican/vault clients

when RGWHTTPManager encounters an http error, it uses
rgw_http_error_to_errno() to map that to a negative posix error code.
RGWHTTPClient::process() returns that mapped error code, and exposes the
original http error via get_http_status()

the http client code for keystone, barbican, and vault were returning
early on the errors from process(), so weren't getting to the http error
checks

these clients now check for specific http errors before testing the
result of process()

Fixes: https://tracker.ceph.com/issues/62989
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 36622e19c7fb217f32f74aada0d224785344f565)

Conflicts:
src/rgw/rgw_auth_keystone.cc null_yield
src/rgw/rgw_kms.cc null_yield, dpp
src/rgw/rgw_auth_keystone.cc
src/rgw/rgw_kms.cc