]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cmake/rocksdb: make sure dependencies build before rocksdb 54123/head
authorCasey Bodley <cbodley@redhat.com>
Thu, 23 Nov 2023 05:12:29 +0000 (00:12 -0500)
committerCasey Bodley <cbodley@redhat.com>
Mon, 27 Nov 2023 14:38:35 +0000 (09:38 -0500)
commit40644ff6bead52a81e4198bd3e9e526020fdb3b1
tree8c5799622fd950123879c4ba799144584bc20100
parente778ad82ea805fe9d949c9a7369232e2d766b73e
cmake/rocksdb: make sure dependencies build before rocksdb

some of rocksdb's dependencies may not have built by the time its
ExternalProject starts, so it can fail with missing headers or
libraries. for example, `uring::uring` may itself be an ExternalProject,
and its include directory won't exist until it starts building:

```
[89/1345] Performing configure step for 'rocksdb_ext'
FAILED: src/rocksdb_ext-prefix/src/rocksdb_ext-stamp/rocksdb_ext-configure build/src/rocksdb_ext-prefix/src/rocksdb_ext-stamp/rocksdb_ext-configure
...
CMake Error in CMakeLists.txt:
  Imported target "uring::uring" includes non-existent path

    "build/src/liburing/src/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.
...
[91/1345] Performing download step (git clone) for 'liburing_ext'
Cloning into 'liburing'...
```

use `add_dependencies(rocksdb_ext)` to make sure all of its dependencies
are available before starting the build

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 353360581a0b802435ecf4273ba79f53deb710e6)
cmake/modules/BuildRocksDB.cmake