]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
test/pybind/rbd: don't ignore from_snapshot in check_diff() 54547/head
authorIlya Dryomov <idryomov@gmail.com>
Sun, 10 Dec 2023 16:01:24 +0000 (17:01 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 15 Dec 2023 10:37:22 +0000 (11:37 +0100)
commitf8ced6d1fe667864bee224104c23b62a2c1c0bfc
treeff1cfe29d61ae077844799651e19c51ef91edfca
parent7aff35c987b9f0e9f0d4198d032737da0ce12b36
test/pybind/rbd: don't ignore from_snapshot in check_diff()

Despite the test in test_diff_iterate() being correct, it started
failing:

    >       check_diff(self.image, 0, IMG_SIZE, 'snap1', [(0, 512, False)])
    ...
    a = [], b = [(0, 512, False)]
    ...
    >       assert a == b
    E       AssertionError

This is because check_diff() drops 'snap1' argument on the floor and
passes None to image.diff_iterate() instead.  This goes back to 2013,
see commit e88fe3cbbc8f ("rbd.py: add some missing functions").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/test/pybind/test_rbd.py