]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
osd/ECBackend.cc: Fix double increment of num_shards_repaired stat 58266/head
authorBill Scales <bill_scales@uk.ibm.com>
Wed, 19 Jun 2024 08:36:06 +0000 (08:36 +0000)
committerAishwarya Mathuria <amathuri@redhat.com>
Tue, 25 Jun 2024 17:09:17 +0000 (22:39 +0530)
commit3e000a5c6d9972a43113d3fa5b8bd5e5c3c478b6
tree5dec855979c36875ba2f8f0cc9492fa44da4d829
parentae67f83842dc03c611d34a4c82be324443b930a7
osd/ECBackend.cc: Fix double increment of num_shards_repaired stat

Commit https://github.com/ceph/ceph/commit/deffa8209f9c0bd300cfdb54d358402bfc6e41c6 refactored
ECBackend::handle_recovery_push for Crimson but accidentally duplicated the code that increments
the num_shards_repaired OSD statistic.

This caused one of the QA tests to fail because the stat reported twice as much repair work
had been completed than expected:

qa/standalone/scrub/osd-scrub-repair.sh: TEST_repair_stats_ec: test 26 = 13

Fixes: https://tracker.ceph.com/issues/64437
Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
(cherry picked from commit e618dc01a7a1bdfaa3e1a6fa2a9a9ac13eee11b8)
src/osd/ECBackend.cc