]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common/TrackedOp: do not count the ops marked as nowarn 58744/head
authorXiubo Li <xiubli@redhat.com>
Wed, 19 Jun 2024 03:27:33 +0000 (11:27 +0800)
committerXiubo Li <xiubli@redhat.com>
Tue, 23 Jul 2024 02:51:19 +0000 (10:51 +0800)
commit3f3c0dcc4b3b4e254b6d3fcb32ade441d60d939c
treef65ca9a2d00295d786377fd32ed9ccb82b022b8e
parent1c7dd7472a8aa5756d215ece8ec9c4ea9b1c4e64
common/TrackedOp: do not count the ops marked as nowarn

If an op is marked as nowarn then it won't be counted as the slow
requests, but currently it will count the initiated time when
iterating the inflight ops.

For example:

[WRN] : 1 slow requests, 1 included below; oldest blocked for > 38.764892 secs
[WRN] : slow request 33.875059 seconds old, received at 2024-06-17T14:14:34.228261+0000: client_request(client.78109915:11369251 mkdir #0x1008ecedea2/chk-89588 2024-06-17T14:14:34.097825+0000 caller_uid=1002960000, caller_gid=0{0,1002960000,}) currently failed to wrlock, waiting

The oldest blocked request is 38.764892 old, but the oldest slow
request reported is 33.875059 old.

Fixes: commit e4160d7e783 ("mds: don't report slow request for blocked filelock request")
Fixes: https://tracker.ceph.com/issues/66557
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 8debaf59b1d07e2dc48e96052800d67155e71ae4)

Conflicts:
- The commit c036b151465("common: support long running ops without
  slow warnings") is missing
src/common/TrackedOp.cc