]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
qa/workunits/rbd: avoid caching effects in luks-encryption.sh 58852/head
authorIlya Dryomov <idryomov@gmail.com>
Fri, 19 Jul 2024 17:35:28 +0000 (19:35 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Thu, 25 Jul 2024 13:44:27 +0000 (15:44 +0200)
commit3fbcfa77cafd24d1d93274d36247a0953210dbb8
tree90b259e81eae81351c7f7cc7f0d6b64e528b3d57
parent58e9504227dc9badfda11ad309d196bec2fcf995
qa/workunits/rbd: avoid caching effects in luks-encryption.sh

Commit 40f6f5224bce ("qa/workunits/rbd: fix issues in
luks-encryption.sh") did the right thing for reads, which solved
most of the issue.  However, it actually made a step in the opposite
direction for writes -- depending on the RBD cache settings, rbd-nbd
virtual devices can behave as physical devices with a volatile write
cache, so fsync is required.

While at it, involving O_DIRECT for reads isn't needed outside of
test_encryption_format().

Fixes: https://tracker.ceph.com/issues/67051
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 9e1c0342e9931e898d795d47f923edd3b4324f4a)

Conflicts:
qa/workunits/rbd/luks-encryption.sh [ commit 1d3de19c4005
  ("tools/rbd: add encryption format support for cloned image")
  not in quincy ]
qa/workunits/rbd/luks-encryption.sh