]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: fix group name bugs in the nvmeof API 60348/head
authorNizamudeen A <nia@redhat.com>
Wed, 9 Oct 2024 14:45:55 +0000 (20:15 +0530)
committerAfreen Misbah <afreen@ibm.com>
Wed, 16 Oct 2024 08:40:40 +0000 (14:10 +0530)
commit4b304f719469c34a0704d41a6621ddd2e1031c90
treef84cc846ea7172c1eb68e5ecc393efb210d53d49
parent649e72305bd164928bf08bca9fc1bbb45328d936
mgr/dashboard: fix group name bugs in the nvmeof API

there are 2 issues

1. in cephadm, i was always using the first daemon to populate the group
   in all the services for the dashboard config.

2. in the API, if there are more than 1 gateways listed in the config,
   rather than chosing a random gateway from the group, raise an
   exception and warn user to specify the gw_group parameter in the api
   request

Fixes: https://tracker.ceph.com/issues/68463
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f9b50b2e88ae5d9ac4f2cab986527a0a12317da9)

 Conflicts:
src/pybind/mgr/cephadm/services/nvmeof.py
src/pybind/mgr/cephadm/services/nvmeof.py
src/pybind/mgr/dashboard/services/nvmeof_conf.py