]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
osd/scrub: discard repair_oinfo_oid() 61590/head
authorRonen Friedman <rfriedma@redhat.com>
Thu, 30 Jan 2025 09:27:58 +0000 (03:27 -0600)
committerRonen Friedman <rfriedma@redhat.com>
Thu, 30 Jan 2025 09:27:58 +0000 (03:27 -0600)
commit7853731a83769ef643659390725d2be077999b8f
tree9a7309addb01b7b53f0550cdc003598d9797f972
parentae82b04b6f2a0176cbbcf56ec3fbc0eea2cb3bc7
osd/scrub: discard repair_oinfo_oid()

repair_oinfo_oid(), called every scrub, has a very specific
functionality: fix the object ID specified in the Object Info
attribute, if different from the ID of the owning object.

This fix was added in 2017, as a response to a unique failure
scenario that was observed in Sepia - probably following a
filesystem bug. See https://tracker.ceph.com/issues/18409 &
https://tracker.ceph.com/issues/20471.

The limited functionality of repair_oinfo_oid() -
only repairing this one specific issue, and only if the OI_ATTR
exists and is decodable - does not justify the overhead of
running it every scrub.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
src/osd/scrubber/pg_scrubber.cc
src/osd/scrubber/pg_scrubber.h
src/osd/scrubber/scrub_backend.cc