]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
osd/scrub: discard repair_oinfo_oid() 61935/head
authorRonen Friedman <rfriedma@redhat.com>
Thu, 30 Jan 2025 09:27:58 +0000 (03:27 -0600)
committerRonen Friedman <rfriedma@redhat.com>
Mon, 17 Feb 2025 17:09:05 +0000 (11:09 -0600)
commitaa22f19831731185e3c115a2b4e5603e8ef2634f
tree2559759682f6f83a0c4c94695e2f464969e3db1b
parentf37f6e7842566f1e13b82063d2226ac34b42ed73
osd/scrub: discard repair_oinfo_oid()

repair_oinfo_oid(), called every scrub, has a very specific
functionality: fix the object ID specified in the Object Info
attribute, if different from the ID of the owning object.

This fix was added in 2017, as a response to a unique failure
scenario that was observed in Sepia - probably following a
filesystem bug. See https://tracker.ceph.com/issues/18409 &
https://tracker.ceph.com/issues/20471.

The limited functionality of repair_oinfo_oid() -
only repairing this one specific issue, and only if the OI_ATTR
exists and is decodable - does not justify the overhead of
running it every scrub.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit 7853731a83769ef643659390725d2be077999b8f)
src/osd/scrubber/pg_scrubber.cc
src/osd/scrubber/pg_scrubber.h
src/osd/scrubber/scrub_backend.cc